Integrate part of scipy elliptic functions and integrals #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* elliptic functions and integrals init * Update special.rst * Update ellip_func_integrals.py * ellipk * ellipk test * elliptic functions and integrals except ellipj * skip tests if scipy version is too low * test getattr import * try for new scipy functions * comment for try catch * change to getattr * Update ellip_func_integrals.py * test benchmark * Update ellip_func_integrals.py * change exception handling * update pytest reason * black reformat * Update ellip_func_integrals.py * change exception handling * Update test_special_execution.py
wjsi
reviewed
Jun 2, 2022
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| scipy.__version__ < "1.8.0", reason="function not implemented in scipy." |
There was a problem hiding this comment.
Comparing versions by strings is not safe. Try looking up parse_version in the code repo and see how we handle dependency versions like pandas.
wjsi
reviewed
Jun 3, 2022
| @@ -12,7 +12,10 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| from ....lib.version import parse as parse_version | |||
There was a problem hiding this comment.
We used to put imports in builtin-thirdparty-Mars order. Please take a look at other py files and change the order.
wjsi
approved these changes
Jun 4, 2022
wjsi
added
mod: tensor
type: feature
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Jun 6, 2022
qinxuye
pushed a commit
that referenced
this pull request
Jun 6, 2022
qinxuye
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Integrate scipy elliptic functions and integrals except ellipj which returns multiple outputs. Some functions are within a try except block because they were not implemented in scipy v1.7, so spspecial.func may throw an AttributeError if the scipy version is low.
Related issue number
#751 (except ellipj)
Check code requirements