-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataframe sort_values with multiple ascendings bug in pandas < 1.4 #3234
Merged
fyrestone
merged 3 commits into
mars-project:master
from
fyrestone:ray_backend_compatible_with_pandas_1.3
Aug 30, 2022
Merged
Fix dataframe sort_values with multiple ascendings bug in pandas < 1.4 #3234
fyrestone
merged 3 commits into
mars-project:master
from
fyrestone:ray_backend_compatible_with_pandas_1.3
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
changed the title
Ray backend dataframe PSRS compatible with pandas 1.3
Fix dataframe sort_values with multiple ascendings bug
Aug 26, 2022
fyrestone
changed the title
Fix dataframe sort_values with multiple ascendings bug
Fix dataframe sort_values with multiple ascendings bug in pandas < 1.4
Aug 26, 2022
chaokunyang
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhongchun
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aresnow1
pushed a commit
to aresnow1/mars
that referenced
this pull request
Sep 7, 2022
mars-project#3234) * Ray backend dataframe PSRS compatible with pandas 1.3 * Remove print * Fix assignment bug Co-authored-by: 刘宝 <po.lb@antgroup.com> (cherry picked from commit c8c4291)
aresnow1
pushed a commit
to aresnow1/mars
that referenced
this pull request
Sep 7, 2022
mars-project#3234) * Ray backend dataframe PSRS compatible with pandas 1.3 * Remove print * Fix assignment bug Co-authored-by: 刘宝 <po.lb@antgroup.com> (cherry picked from commit c8c4291)
aresnow1
pushed a commit
to aresnow1/mars
that referenced
this pull request
Sep 7, 2022
mars-project#3234) * Ray backend dataframe PSRS compatible with pandas 1.3 * Remove print * Fix assignment bug Co-authored-by: 刘宝 <po.lb@antgroup.com> (cherry picked from commit c8c4291)
qianduoduo0904
pushed a commit
to qianduoduo0904/mars
that referenced
this pull request
Sep 22, 2022
mars-project#3234) * Ray backend dataframe PSRS compatible with pandas 1.3 * Remove print * Fix assignment bug Co-authored-by: 刘宝 <po.lb@antgroup.com> (cherry picked from commit c8c4291)
UranusSeven
pushed a commit
to xorbitsai/mars
that referenced
this pull request
Sep 22, 2022
mars-project#3234) * Ray backend dataframe PSRS compatible with pandas 1.3 * Remove print * Fix assignment bug Co-authored-by: 刘宝 <po.lb@antgroup.com> (cherry picked from commit c8c4291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The numpy array is immutable if it is got from shared memory. But, pandas < 1.4 has item setting bugs: pandas-dev/pandas#43406.
pandas >= 1.4.x has fixed this bug. So, this PR is to make the Ray backend works with pandas < 1.4
This code raises a ValueError in pandas < 1.4, but works in pandas >= 1.4
Related issue number
Fixes #3215
Check code requirements