Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #151

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

pre-commit-ci bot and others added 2 commits July 1, 2024 20:55
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0)
- [github.com/asottile/blacken-docs: 1.16.0 → 1.18.0](adamchainz/blacken-docs@1.16.0...1.18.0)
- [github.com/pre-commit/mirrors-mypy: v1.10.0 → v1.10.1](pre-commit/mirrors-mypy@v1.10.0...v1.10.1)
output-format = "full"

[tool.ruff.format]
docstring-code-format = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! does this mean we can remove blacken-docs from pre-commit? 🤔

Copy link
Member

@lafrech lafrech Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. There seems to be a difference between

I didn't take the time to read those threads and wonder if the latter would be enough for our needs.

I picked this line from marshmallow's pyproject.toml without much thinking, TBH.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah woops i didn't realize this was already in marshmallow. looks like formatting RST docs isn't implemented yet, so we still need blacken-docs for now

@sloria sloria merged commit 1db8ed9 into main Jul 3, 2024
6 checks passed
@sloria sloria deleted the pre-commit-ci-update-config branch July 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants