Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Nested Partial Fix #2150

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

deckar01
Copy link
Member

Fixes #2149

59a4329 regressed the behavior of schemas using partial when they are passed to Nested.

The default value for partial in schema arguments was normalized to None in the few places it was False. This ensures that partial=False is treated as an explicit request to disable partial loading in nested schemas, and partial=None is treated as a request to defer to nested schemas' partial behavior.

This changes the behavior of schemas without partial defined when they contain nested schemas with partial defined, but the behavior introduced by 3.0.0b19 was untested, undocumented, and counterintuitive, so I am hesitant to label this backwards incompatible.

@lafrech lafrech merged commit 91147b2 into marshmallow-code:dev Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested partial not working as expected
2 participants