Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit update #2215

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Pre commit update #2215

merged 4 commits into from
Dec 20, 2023

Conversation

lafrech
Copy link
Member

@lafrech lafrech commented Dec 5, 2023

The "extra require" dependency versions in setup.py are not the ones used in the CI tests.

CI tests use tox, which runs an old version of pre-commit, which in turn uses its own versions of lint dependencies.

  • Update pre-commit version in tox.ini
  • Update flake8-bugbear while I'm at it (it is not autoupdated)
  • Remove lint dependencies listed in setup.py (apart from pre-commit)

This will save us a few useless dependabot PRs about unused stuff (leaving us with the false impression that our dependencies are up-to-date). We still need to update pre-commit in tox.ini manually because dependabot won't pick that up.

Users are advised to call pre-commit to run CI, either automatically on commit or using

pre-commit run --all-files

@lafrech lafrech merged commit 2ef3f44 into dev Dec 20, 2023
8 checks passed
@lafrech lafrech deleted the pre-commit_update branch December 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant