Randomize capitalization #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the length of a passphrase has a significantly larger impact than its complexity, you may still want to increase the complexity by utilizing a larger character pool – for example by capitalizing words in your passphrase.
Until now, this package supported a
capitalizeoption that would capitalize the first character of every word in the passphrase when enabled. However, an attacker may assume that a passphrase uses this steady pattern. Thus, the entropy improvement is gone.The new randomized word capitalization is inspired by password managers like 1Password that have shifted from generating passphrases with capitalized characters in every word to uppercasing one randomly selected word in the passphrase.
The change in newly generated passphrases looks like this:
Additionally, capitalization is enabled by default now.