feat: chordpro & chords over words compatibility #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return [...emptyLines, ...lines, trailingLine]; | ||
| } | ||
|
|
||
| function pairChordsWithLyrics(chordsLine, lyricsLine) { |
There was a problem hiding this comment.
Function pairChordsWithLyrics has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
| } | ||
|
|
||
| // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars | ||
| function arrangeChordSheetLines(chordSheetLines: any[]) { |
There was a problem hiding this comment.
Function arrangeChordSheetLines has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
| return [...emptyLines, ...lines, trailingLine]; | ||
| } | ||
|
|
||
| function pairChordsWithLyrics(chordsLine, lyricsLine) { |
There was a problem hiding this comment.
Function pairChordsWithLyrics has 30 lines of code (exceeds 25 allowed). Consider refactoring.
… on master to text formatter
martijnversluis
force-pushed
the
gh-307-chordpro-to-chords-over-words
branch
from
6569abb to
d582eb6
Compare
|
Code Climate has analyzed commit d582eb6 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.