Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace as label and custom metric prefix options #121

Merged
merged 1 commit into from
May 5, 2020

Conversation

rivik
Copy link
Contributor

@rivik rivik commented May 5, 2020

#13 - seems I fixed it and it's backward compatible =)

@martin-helmich
Copy link
Owner

Oh, wow 😍 I'll take a look ASAP. 👍

@codeclimate
Copy link

codeclimate bot commented May 5, 2020

Code Climate has analyzed commit 8bebf41 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍 I especially like your solution using a prometheus.Gatherers list -- very elegant, and made the whole thing a lot less painful than I feared it to be.

@martin-helmich martin-helmich changed the title namespace as label Namespace as label and custom metric prefix options May 5, 2020
@martin-helmich martin-helmich merged commit 8ffdfa9 into martin-helmich:master May 5, 2020
@martin-helmich martin-helmich mentioned this pull request May 5, 2020
@rivik
Copy link
Contributor Author

rivik commented May 5, 2020

Thanks for the great and fast review (and useful tool) 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants