Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenTelemetry #1020

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add OpenTelemetry #1020

merged 1 commit into from
Jan 26, 2024

Conversation

martincostello
Copy link
Owner

Add OpenTelemetry to the Lambda.

@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Jan 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f1527ea) 94.80% compared to head (bfde017) 93.93%.

❗ Current head bfde017 differs from pull request most recent head 0300d00. Consider uploading reports for the commit 0300d00 to get more accurate results

Files Patch % Lines
src/LondonTravel.Skill/AlexaFunction.cs 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   94.80%   93.93%   -0.87%     
==========================================
  Files          44       44              
  Lines         558      577      +19     
  Branches       57       59       +2     
==========================================
+ Hits          529      542      +13     
- Misses          9       15       +6     
  Partials       20       20
Flag Coverage Δ
linux 93.93% <95.83%> (+0.02%) ⬆️
macos 93.93% <95.83%> (-0.87%) ⬇️
windows 93.93% <95.83%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello mentioned this pull request Jan 23, 2024
Merged
1 task
@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 579.17 ms 990 ms 192 MB 86 MB 410.67 ms
UnknownIntent 27.70 ms 28 ms 192 MB 86 MB -
Status 3373.73 ms 3374 ms 192 MB 101 MB -
Disruption 99.88 ms 100 ms 192 MB 101 MB -
SessionEnded 27.01 ms 28 ms 192 MB 101 MB -
Stop 26.66 ms 27 ms 192 MB 101 MB -
Launch 27.97 ms 28 ms 192 MB 101 MB -
Help 26.90 ms 27 ms 192 MB 101 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 470.50 ms 856 ms 192 MB 73 MB 385.20 ms
UnknownIntent 27.55 ms 28 ms 192 MB 73 MB -
Status 1878.99 ms 1879 ms 192 MB 87 MB -
Disruption 2487.38 ms 2891 ms 192 MB 102 MB 402.94 ms
SessionEnded 26.80 ms 27 ms 192 MB 102 MB -
Stop 27.81 ms 28 ms 192 MB 102 MB -
Launch 27.52 ms 28 ms 192 MB 102 MB -
Help 27.03 ms 28 ms 192 MB 103 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 466.88 ms 872 ms 192 MB 73 MB 404.88 ms
UnknownIntent 26.52 ms 27 ms 192 MB 73 MB -
Status 1870.45 ms 1871 ms 192 MB 87 MB -
Disruption 1213.19 ms 1214 ms 192 MB 88 MB -
SessionEnded 26.68 ms 27 ms 192 MB 88 MB -
Stop 27.53 ms 28 ms 192 MB 88 MB -
Launch 26.88 ms 27 ms 192 MB 88 MB -
Help 27.50 ms 28 ms 192 MB 88 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 1495.75 ms 1859 ms 192 MB 85 MB 363.15 ms
UnknownIntent 53.62 ms 54 ms 192 MB 85 MB -
Status 3153.27 ms 3516 ms 192 MB 98 MB 362.63 ms
Disruption 96.73 ms 97 ms 192 MB 98 MB -
SessionEnded 61.35 ms 62 ms 192 MB 98 MB -
Stop 57.35 ms 58 ms 192 MB 98 MB -
Launch 27.99 ms 28 ms 192 MB 98 MB -
Help 26.47 ms 27 ms 192 MB 98 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 1417.37 ms 1807 ms 192 MB 85 MB 389.34 ms
UnknownIntent 25.99 ms 26 ms 192 MB 85 MB -
Status 2391.64 ms 2392 ms 192 MB 96 MB -
Disruption 101.91 ms 102 ms 192 MB 96 MB -
SessionEnded 35.75 ms 36 ms 192 MB 97 MB -
Stop 27.02 ms 28 ms 192 MB 97 MB -
Launch 27.31 ms 28 ms 192 MB 97 MB -
Help 26.73 ms 27 ms 192 MB 97 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 1519.36 ms 1913 ms 192 MB 86 MB 393.10 ms
UnknownIntent 26.68 ms 27 ms 192 MB 86 MB -
Status 1863.45 ms 1864 ms 192 MB 97 MB -
Disruption 94.95 ms 95 ms 192 MB 98 MB -
SessionEnded 82.82 ms 83 ms 192 MB 98 MB -
Stop 33.28 ms 34 ms 192 MB 98 MB -
Launch 41.35 ms 42 ms 192 MB 98 MB -
Help 62.13 ms 63 ms 192 MB 98 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration
Cancel 1486.04 ms 1868 ms 192 MB 86 MB 381.88 ms
UnknownIntent 27.73 ms 28 ms 192 MB 86 MB -
Status 3292.03 ms 3697 ms 192 MB 100 MB 404.34 ms
Disruption 94.36 ms 95 ms 192 MB 100 MB -
SessionEnded 27.64 ms 28 ms 192 MB 100 MB -
Stop 29.14 ms 30 ms 192 MB 100 MB -
Launch 58.25 ms 59 ms 192 MB 101 MB -
Help 27.46 ms 28 ms 192 MB 101 MB -

@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration Trace
Cancel 1625.84 ms 2015 ms 192 MB 87 MB 388.18 ms 🔗
UnknownIntent 66.14 ms 67 ms 192 MB 88 MB - 🔗
Status 1793.30 ms 1794 ms 192 MB 98 MB - 🔗
Disruption 92.32 ms 93 ms 192 MB 98 MB - 🔗
SessionEnded 27.24 ms 28 ms 192 MB 99 MB - 🔗
Stop 26.62 ms 27 ms 192 MB 99 MB - 🔗
Launch 26.95 ms 27 ms 192 MB 99 MB - 🔗
Help 72.45 ms 73 ms 192 MB 99 MB - 🔗

@martincostello
Add OpenTelemetry
0300d00 
Add OpenTelemetry to the skill.
@martincostello
Copy link
Owner Author

/deploy dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

🧪 Tests for deployment to dev passed ✅

@github-actions GitHub Actions
Copy link

Payload Duration Billed Duration Memory Size Max Memory Used Init Duration Trace
Cancel 1433.40 ms 1848 ms 192 MB 84 MB 414.22 ms 🔗
UnknownIntent 27.05 ms 28 ms 192 MB 84 MB - 🔗
Status 1849.00 ms 1849 ms 192 MB 95 MB - 🔗
Disruption 115.89 ms 116 ms 192 MB 95 MB - 🔗
SessionEnded 26.66 ms 27 ms 192 MB 96 MB - 🔗
Stop 27.51 ms 28 ms 192 MB 96 MB - 🔗
Launch 54.51 ms 55 ms 192 MB 96 MB - 🔗
Help 30.88 ms 31 ms 192 MB 96 MB - 🔗

@martincostello martincostello marked this pull request as ready for review January 26, 2024 20:03
@martincostello martincostello merged commit f837f47 into main Jan 26, 2024
11 checks passed
@martincostello martincostello deleted the add-opentelemetry branch January 26, 2024 20:03
@martincostello
Copy link
Owner Author

Adding OTel increases the deployed application size from ~11.9MB to ~14.9MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martincostello