Update multiple SDK version properties #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all occurrences of the .NET SDK version to handle the scenario where the `tools:dotnet` property also contains the SDK version.
martincostello
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 88.82% 88.92% +0.09%
==========================================
Files 2 2
Lines 349 352 +3
Branches 66 66
==========================================
+ Hits 310 313 +3
Misses 33 33
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Change how the dots in the version are escaped.
Fix copy-pasta in test name.
martincostello
added a commit
that referenced
this pull request
Jan 16, 2024
Merged
martincostello
added a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all occurrences of the .NET SDK version to handle the scenario where the
tools:dotnetproperty also contains the SDK version.See https://github.com/dotnet/aspnetcore/pull/53424/files#r1454015608.
/cc @wtgodbe