Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property tests for PJR and EJR work with brute force and weighted profiles #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DominikPeters
Copy link
Contributor

The property testers all support weighted profiles, but for PJR and EJR the code assumed this is not the case. I removed the relevant if-clauses.

@DominikPeters DominikPeters force-pushed the weighted-property-test-brute-force branch from 2e91363 to bad1f18 Compare February 17, 2025 18:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (321240e) to head (bad1f18).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   91.95%   92.07%   +0.11%     
==========================================
  Files          11       11              
  Lines        3159     3155       -4     
  Branches     1003      998       -5     
==========================================
  Hits         2905     2905              
+ Misses        146      144       -2     
+ Partials      108      106       -2     
Files with missing lines Coverage Δ
abcvoting/properties.py 96.76% <ø> (+0.73%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321240e...bad1f18. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants