Enhance in_place construction #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation required ad least a move-constructor for in-place construction. This made it impossible to directly, create an optional of a type without copy and move operators. A workaround is using the variadic emplace function, but it requires to construct the object in two steps. std::optional does not require any copy or move operation for in-place construction
|
Thanks for your contribution. I'll tend to |
martinmoene
pushed a commit
that referenced
this pull request
Sep 16, 2021
The current implementation required ad least a move-constructor for in-place construction. This made it impossible to directly, create an optional of a type without copy and move operators. A workaround is using the variadic emplace function, but it requires to construct the object in two steps. std::optional does not require any copy or move operation for in-place construction
martinmoene
added a commit
that referenced
this pull request
Sep 16, 2021
martinmoene
added a commit
that referenced
this pull request
Sep 16, 2021
martinmoene
added a commit
that referenced
this pull request
Sep 16, 2021
|
Think all is taken care of now and the PR can be closed now. |
|
thank you @martinmoene can I ask if there are any plans for a new release? |
|
@fekir A new release seems in order. Will address that in the coming days. |
|
Released optional lite version 3.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation required ad least a move-constructor for
in-place construction.
This made it impossible to directly, create an optional of a type
without copy and move operators.
A workaround is using the variadic emplace function, but it requires to
construct the object in two steps.
std::optional does not require any copy or move operation for in-place
construction