Skip to content

Commit

Permalink
Makefile: Serialize git cloning targets
Browse files Browse the repository at this point in the history
The `bots`, `test/common`, and `src/lib/patternfly` targets cannot be
run in parallel, as they compete for the git lock.

Serialize them by adding arbitrary dependencies to them.
  • Loading branch information
martinpitt committed Sep 8, 2020
1 parent 203604a commit cfced19
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ src/lib/patternfly/_fonts.scss:
git restore --staged pkg/lib/patternfly
mkdir -p src/lib && mv pkg/lib/patternfly src/lib/patternfly && rmdir -p pkg/lib

# force serialization of the targets that call git, as they compete for the git lock
bots: test/common
test/common: src/lib/patternfly/_fonts.scss

$(NODE_MODULES_TEST): package.json
# if it exists already, npm install won't update it; force that so that we always get up-to-date packages
rm -f package-lock.json
Expand Down

0 comments on commit cfced19

Please sign in to comment.