Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings file broken #48

Closed
dbreen opened this issue Sep 15, 2017 · 1 comment
Closed

Settings file broken #48

dbreen opened this issue Sep 15, 2017 · 1 comment

Comments

@dbreen
Copy link

dbreen commented Sep 15, 2017

The settings.py file is trying to pull each setting from a dict, but it's calling getattr which will not work, so it always uses the defaults.

E.g.,

SESSION_REDIS_HOST = getattr(SESSION_REDIS, 'host', 'localhost')

Should be:

SESSION_REDIS_HOST = SESSION_REDIS.get('host', 'localhost')
martinrusev added a commit that referenced this issue Sep 16, 2017
@martinrusev
Dict config bug fixes, related to #48
b4dcd0b
@dbreen
Copy link
Author

dbreen commented Sep 18, 2017

Thanks! That fixed it.

@dbreen dbreen closed this as completed Sep 18, 2017
@pyup-bot pyup-bot mentioned this issue Oct 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbreen