Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse flags #126

Closed
zevaverbach opened this issue Jul 25, 2018 · 6 comments · Fixed by #134
Closed

parse flags #126

zevaverbach opened this issue Jul 25, 2018 · 6 comments · Fixed by #134

Comments

@zevaverbach
Copy link
Contributor

zevaverbach commented Jul 25, 2018 •
edited
Loading

Parse flags in parse_email and add them as a list parsed_email.flags. Would you accept such a PR?
@zevaverbach
Copy link
Contributor Author

this could be implemented using imaplib.ParseFlags.

@zevaverbach
Copy link
Contributor Author

possibly this would also help resolve #22.

@martinrusev
Copy link
Owner

@zevaverbach This would be a very helpful addition

zevaverbach added a commit to zevaverbach/imbox that referenced this issue Jul 26, 2018
@zevaverbach
amended 8df7d7c to reflect manual changes made to README.rst in c…
7b7bfb6 
…urrent master, but also added `inbox_` to several var names to make that explicit in the documentation. Added flags to messages returned by `fetch_email_by_uid`, using the new function `parse_flags` in `parser.py`. Fixes martinrusev#126.
zevaverbach added a commit to zevaverbach/imbox that referenced this issue Jul 26, 2018
@zevaverbach
Added missing documentation for all supported query keyword arguments. …
9cffb51 
…Fixes martinrusev#124.  Added Pycharm directory to .gitignore.

Fixed var names in documentation of query keywords

moved Messages and Imbox to their own modules, imported Imbox.imbox into __init__.py and put it in __all__. fixes martinrusev#130.

clarified in documentation and Imbox.messages logging that, unless a folder is specified in the kwargs to Imbox.messages, the returned messages will be from the inbox.  In the documentation this is accomplished exclusively by the var names. fixes martinrusev#128.

amended `8df7d7c` to reflect manual changes made to `README.rst` in current master, but also added `inbox_` to several var names to make that explicit in the documentation.  Added flags to messages returned by `fetch_email_by_uid`, using the new function `parse_flags` in `parser.py`.  Fixes martinrusev#126.

added TODO back into query.py
@zevaverbach zevaverbach mentioned this issue Jul 26, 2018
Merged
@zevaverbach zevaverbach mentioned this issue Jul 27, 2018
Closed
@pycebs
Copy link

pycebs commented Aug 13, 2018

@zevaverbach Will this be pushed to PyPI anytime soon?

@zevaverbach
Copy link
Contributor Author

zevaverbach commented Aug 14, 2018 •
edited
Loading

@pycebs I'm not a maintainer of the project, so you'll have to ask @martinrusev. However, you could pip install pip install git+https://github.com/martinrusev/imbox.git while you wait for that.

@martinrusev
Copy link
Owner

@pycebs Just pushed to PyPI, all the recent changes are wrapped in the 0.9.6 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@martinrusev @zevaverbach @pycebs