-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created vendors package #139
Commits on Jul 26, 2018
-
added basic structure for vendors module, including mostly blank Gmai…
…lMessages class. 'vendor' is now a kwarg for Imbox, but there's also a lookup dict created in vendors/__init__.py for 'magic' determination of the vendor from the hostname.
Configuration menu - View commit details
-
Copy full SHA for 7d11b59 - Browse repository at this point
Copy the full SHA 7d11b59View commit details
Commits on Jul 27, 2018
-
added
authentication_error_message
as a class attribute toImbox
.…… If `Imbox.vendor` is not None, look for a custom authentication error string, and raise it if there's a problem logging in. The default error value is raised if there is no custom string. created `name_authentication_string_dict` from all subclasses of `Messages` in `vendors/__init__.py`, for the lookup mentioned above. Implement architecture discussed in martinrusev#131, deciding whether to use `Messages` or a subclass of it in `Imbox.messages` based on the `Imbox.vendor` value. Use the `folder_lookup` dict, present on `Messages` but only filled in on its subclasses, to select the right folder based on a lowercased "standard" name given as the value of `folder`. created a blank `folder_lookup` on `Messages`. filled in the first vendor that subclasses `Messages`, `GmailMessages`. It contains class attributes `authentication_error_message`, `hostname`, `name`, used for purposes described above, as well as `folder_lookup` which is a dict containing aliases, sometimes several, for Gmail's unique folder naming scheme. These aliases are meant to be "human-friendly" for intuitive `folder` selection in calls to `Imbox.messages`. fixes martinrusev#131.
Configuration menu - View commit details
-
Copy full SHA for 1fbb851 - Browse repository at this point
Copy the full SHA 1fbb851View commit details -
prevent too much bookkeeping in vendors/__init__.py by adding each ve…
…ndor.__name__ to __all__ from the vendors list.
Configuration menu - View commit details
-
Copy full SHA for 6f3cc1a - Browse repository at this point
Copy the full SHA 6f3cc1aView commit details -
added basic structure for vendors module, including mostly blank Gmai…
…lMessages class. 'vendor' is now a kwarg for Imbox, but there's also a lookup dict created in vendors/__init__.py for 'magic' determination of the vendor from the hostname. added `authentication_error_message` as a class attribute to `Imbox`. If `Imbox.vendor` is not None, look for a custom authentication error string, and raise it if there's a problem logging in. The default error value is raised if there is no custom string. created `name_authentication_string_dict` from all subclasses of `Messages` in `vendors/__init__.py`, for the lookup mentioned above. Implement architecture discussed in martinrusev#131, deciding whether to use `Messages` or a subclass of it in `Imbox.messages` based on the `Imbox.vendor` value. Use the `folder_lookup` dict, present on `Messages` but only filled in on its subclasses, to select the right folder based on a lowercased "standard" name given as the value of `folder`. created a blank `folder_lookup` on `Messages`. filled in the first vendor that subclasses `Messages`, `GmailMessages`. It contains class attributes `authentication_error_message`, `hostname`, `name`, used for purposes described above, as well as `folder_lookup` which is a dict containing aliases, sometimes several, for Gmail's unique folder naming scheme. These aliases are meant to be "human-friendly" for intuitive `folder` selection in calls to `Imbox.messages`. fixes martinrusev#131. prevent too much bookkeeping in vendors/__init__.py by adding each vendor.__name__ to __all__ from the vendors list.
Configuration menu - View commit details
-
Copy full SHA for 86cf1fb - Browse repository at this point
Copy the full SHA 86cf1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87e42a9 - Browse repository at this point
Copy the full SHA 87e42a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f82ce52 - Browse repository at this point
Copy the full SHA f82ce52View commit details