Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a forgotten parameter in a log line #143

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Add a forgotten parameter in a log line #143

merged 1 commit into from
Jul 28, 2018

Conversation

sblondon
Copy link
Contributor

So the encoding parameter will be logged.

I changed the formatted string to not raise an error if the encoding parameter equals None. However, it should never occur and type hint enforces to string type.

Tested with python 3.6

@sblondon sblondon mentioned this pull request Jul 28, 2018
Merged
@martinrusev martinrusev merged commit 079569d into martinrusev:master Jul 28, 2018
AT0myks added a commit to AT0myks/imbox that referenced this pull request Jan 17, 2022
@AT0myks
Reinstate fix from martinrusev#143 that was overwritten in martinruse…
6cdc0f0 
…v#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sblondon @martinrusev