fix: move buffer flushing from dirac-pilot.py to PilotCommand wrapper

martynia · Oct 27, 2023 · 92b14e2 · 92b14e2
1 parent ba18fb2
commit 92b14e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Pilot/dirac-pilot.py b/Pilot/dirac-pilot.py
@@ -110,7 +110,6 @@
         command, module = getCommand(pilotParams, commandName)
         if command is not None:
             command.log.info("Command %s instantiated from %s" % (commandName, module))
-            command.log.buffer.flush()
             command.execute()
         else:
             log.error("Command %s could not be instantiated" % commandName)

diff --git a/Pilot/pilotCommands.py b/Pilot/pilotCommands.py
@@ -84,6 +84,7 @@ def wrapper(self):
 
         try:
             ret = func(self)
+            self.log.buffer.flush()
             return ret
 
         except SystemExit as exCode:  # or Exception ?
@@ -92,7 +93,7 @@ def wrapper(self):
             self.log.info(
                 "Flushing the remote logger buffer for pilot on sys.exit(): %s (exit code:%s)" % (pRef, str(exCode))
             )
-            self.log.buffer.flush()  # flush the buffer unconditionally (on sys.exit() and return).
+            self.log.buffer.flush()  # flush the buffer unconditionally (on sys.exit()).
             try:
                 sendMessage(self.log.url, self.log.pilotUUID, "finaliseLogs", {"retCode": str(exCode)})
             except Exception as exc: