fix(lib/irc): Use protected loops when iterating channels to remove users #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue referenced in #172. |
|
This looks reasonable, I just don't have time to merge and test it right now, but I'll endeavour to do that in the next day or so :-) |
|
Haha. Alright. I did run the test file(as well as the mocha tests), and those seemed to work. I'll admit I didn't try using this version with my bot. I'll try that and post back my results as well. |
osslate
pushed a commit
that referenced
this pull request
May 29, 2014
fix(lib/irc): Use protected loops when iterating channels to remove users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are iterating objects, we need to be sure that the property actually exists. Iterating the keys of the object accomplishes this.
Also because we are only iterating what we want, we can drop the type checks.