Fixes #235 type error where channel does not exist #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The package.json changes were updated by |
|
package.json changes seem to be indentation, and thus not something that should be changed in a PR. I'd suggest dumping that commit and then using only one commit for your change overall. |
|
will do |
|
Fixed! |
osslate
pushed a commit
that referenced
this pull request
May 29, 2014
Fixes #235 type error where channel does not exist
|
I'm still a bit curious as to how this happens, but I didn't have time to really dig into the code fully to understand why, might be a latent bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Not sure if it's even a good fix, but I found it necessary to have at least this much, otherwise it'd just explode and kill my proxy server (I couldn't wrap it in
tryeither)