Add proper long line wrapping. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will note that this is similar to #142, but the line wrapping implementation itself is a lot cleaner. I don't see where that code actually sets |
ghost
mentioned this pull request
|
+1 |
added 3 commits
January 6, 2015 23:05
When sending a message to IRC, the message is relayed to other servers and other clients by the server and needs to fit within the max line length for server messages (512). What this means is that the actual content of the message needs to be truncated based on the length of the user's nick, hostname, and the kind of message being sent (PRIVMSG, NOTICE). The current code, in addition to hardcoding the wrap length at the absolute max line length (not taking any of this into consideration), is rather ugly and hard to follow. I've abstracted the logic into something easier to follow, correct, and reuseable. It'll be easy to expand it to ACTION. TODO: maintain colors and other formatting across wrapped messages. Textual does this for PRIVMSGs, at least, so we can try looking there for inspiration.
This fixes the style to be more consistent with the existing code and makes the line length calculation actually take the target into consideration. It also makes some methods private according to whether they are called by the end user or not.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a message to IRC, the message is relayed to other
servers and other clients by the server and needs to fit within
the max line length for server messages (512). What this means
is that the actual content of the message needs to be truncated
based on the length of the user's nick, hostname, and the kind
of message being sent (PRIVMSG, NOTICE). The current code,
in addition to hardcoding the wrap length at the absolute
max line length (not taking any of this into consideration),
is rather ugly and hard to follow. I've abstracted the logic
into something easier to follow, correct, and reuseable. It'll
be easy to expand it to ACTION.
TODO: maintain colors and other formatting across wrapped
messages. Textual does this for PRIVMSGs, at least, so we can try
looking there for inspiration.