Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis with lint and tests #271

Merged
24 commits merged into from
Jan 7, 2015

Conversation

jirwin
Copy link
Collaborator

@jirwin jirwin commented Jan 6, 2015

What

Start using travis-ci for CI. Use jscs for lint, and run npm test for tests.

Why

CI helps speed up development with automatic validation of incoming Pull Requests. Using a linter makes a consistent code style for readability and catching simple and common bugs.

Lint details

Using jscs this implements mostly the airbnb javascript style. The differences are:

  • 4 spaces for indentation instead of 2
  • camelCase isn't required for Object properties
  • self is the accepted keyword for storing context across closures instead of _this
  • Don't require a single var statement per scope

… to update before doing anything so tests can pass.
…ti-line if statements can't be on a single line.
ghost pushed a commit that referenced this pull request Jan 7, 2015
@ghost ghost merged commit 8aa8b03 into martynsmith:0.3.x Jan 7, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant