WEBIRC support

[Trinitas]

Webirc is used for multiple users to connect from your node-irc server to irc to get the clients ip.
Get the users ip and hostname and send it like this:
webirc = {"pass":"WebIrcPassWord","host":"my.host.com", "ip":"123.123.12.12"};

http://wiki.mibbit.com/index.php/Enable_Mibbit_on_Your_IRC_Server
How to configure your server for Webirc can also be found in your irc server dokumentation.

[Trinitas]

wrong branch?

[jirwin]

This is the wrong branch. You just have some lint errors to fix. Run npm run-script lint locally to see what they are.

I think this patch looks pretty good now!

[jirwin]

This might be better as if (self.opt.webirc.ip) {. Currently this would run if an IP was an empty string as well.

[jirwin]

this still has the issue of the case where self.opt.webirc.ip === ''. It is probably better to check the value instead of trusting the type. Using if (self.opt.webirc.ip) { looks for a falsy value, and the empty string('') will evaluate to false.

[Trinitas]

it's a string not a boolean value

[jirwin]

$ node
> var bill = "I'm just a bill";
> var empty = "";
> if (bill) console.log('This is a truthy statement');
This is a truthy statement
> if (empty) console.log('Since this value is empty it will not print')
> if (typeof empty !== null) console.log('Since empty is a string, even though this is empty, it will evaluate to true and continue')
Since empty is a string, even though this is empty, it will evaluate to true and continue

[Trinitas]

Line 661 and 688" if (self.opt.password !== null) " should i change it to true/false also or leave it?
Also a string. not writed by me. Btw i don't get any errors on my JSlint in notepad++ Edit: it was JSHint

[ghost]

As I said in a previous pull req, I'm not sure why this needs to be a part of node-irc proper and can't just be handled via a registered event handler. Can you explain that, please?

[ghost]

I have trawled the charybdis source code and I see no indication that WEBIRC needs to be sent immediately upon connecting.

[Trinitas]

I gonna test that new pull with socket.localAddress and see if that fixed the problem with multiple ip
Problem on my server. But here is some reading about Webirc

When a user connects through an indirect method, such web clients, the indirect client sends its own IP address instead of sending the user's IP address unless WebIRC is implemented by both the client and the server.

Method:
Before the client sends the PASS, USER or NICK commands it should send:WEBIRC password user hostname ip

Source:
https://kiwiirc.com/docs/webirc.

Compatible with a bunch of irc servers