Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some simple CTCP support #58

Merged
merged 2 commits into from
Apr 14, 2012
Merged

add some simple CTCP support #58

merged 2 commits into from
Apr 14, 2012

Conversation

thejh
Copy link
Contributor

@thejh thejh commented Nov 6, 2011

This adds some simple CTCP support.

  • ctcp event with from, to, text, type
  • ctcp-privmsg event with from, to, text
  • ctcp-notice event with from, to, text
  • ctcp-version event with from, to
  • action event with from, to, text
  • .ctcp(to, type, text) method
  • automatic answer to CTCP PING

@martynsmith
Copy link
Owner

Are you able to update the documentation too? I haven't looked over the code too closely yet (it just so happened that I was looking at implementing some CTCP support myself) :-)

@thejh
Copy link
Contributor Author

thejh commented Nov 16, 2011

Added some documentation.

@akavlie
Copy link
Contributor

akavlie commented Jan 8, 2012

Yes please. Just looking into support for ACTION events now; best that node-irc send that as a separate event.

Side note: IRC conventions seem to be really poorly documented. Try a search for "\u0001 ACTION" on Google. You don't get anything comprehensive or authoritative.

@martynsmith
Copy link
Owner

This looks pretty reasonable. I'll have a crack at merging it soon.

@martynsmith martynsmith merged commit 5d0aa39 into martynsmith:master Apr 14, 2012
Half-Shot referenced this pull request in matrix-org/node-irc Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants