Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add app noctis-iv-lr #2154

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Van020530
Copy link
Contributor

Modern source port of Noctis IV

log: add app

@Van020530
Copy link
Contributor Author

/check build

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 28, 2024

Deepin Obs Bot
Starting find obs webhook event and retrigger!

@kamiyadm
Copy link
Contributor

没升版本?

Modern source port of Noctis IV

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt中,target_link_libraries的调用使用了硬编码的路径,这可能会导致在不同的环境或部署中出现问题。建议使用环境变量或配置文件来设置库文件的路径。
  • DESKTOP_FILE_CONTENT字符串中的换行符被移除,这可能会影响在桌面环境中正确显示程序图标的配置。建议保持字符串的换行格式,以便在不同平台上正确显示。
  • MY_DATADIR宏的定义使用了大写字母,这可能会导致在某些情况下出现错误。建议使用小写字母或者其他区分大小写的字符串比较方法。
  • sa_open函数中,MY_DATADIR宏没有正确地包含在文件路径中,这可能会导致文件找不到的问题。建议确保路径正确地使用了MY_DATADIR
  • 代码中没有对fopen的返回值进行错误检查,这可能会导致在文件打开失败时出现未处理的异常。建议添加错误检查来确保文件的正确打开。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 8dd8898 into martyr-deepin:master May 30, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants