Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unicode filename #78

Merged
merged 1 commit into from
May 13, 2022
Merged

Avoid unicode filename #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/panic/internal/utf8/ùtf8.go → cmd/panic/internal/utf8/utf8.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
// that can be found in the LICENSE file.

// Package ùtf8 tests a package and function with non-ASCII names.
//
// The filename itself does not contain unicode as this causes issues
tbg marked this conversation as resolved.
Show resolved Hide resolved
// importing panicparse under bazel. For more context, see PR #78.
package ùtf8

// Strùct is a totally normal structure with a totally normal name.
Expand Down
2 changes: 1 addition & 1 deletion stack/context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,7 +2023,7 @@ func testPanicUTF8(t *testing.T, s *Snapshot, b *bytes.Buffer, ppDir string) {
),
// See TestCallUTF8 in stack_test.go for exercising the methods on
// Call in this situation.
pathJoin(ppDir, "internal", "utf8", "ùtf8.go"),
pathJoin(ppDir, "internal", "utf8", "utf8.go"),
10),
newCallLocal("main.glob..func21", Args{}, pathJoin(ppDir, "main.go"), 322),
newCallLocal("main.main", Args{}, pathJoin(ppDir, "main.go"), 340),
Expand Down
10 changes: 5 additions & 5 deletions stack/stack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ func TestCallPkg(t *testing.T) {
// See testPanicUTF8 in context_test.go.
name: "UTF8",
f: "github.com/maruel/panicparse/cmd/panic/internal/%c3%b9tf8.(*Strùct).Pànic",
s: "/gpremote/src/github.com/maruel/panicparse/cmd/panic/internal/ùtf8/ùtf8.go",
DirSrc: pathJoin("ùtf8", "ùtf8.go"),
SrcName: "ùtf8.go",
LocalSrcPath: "/gplocal/src/github.com/maruel/panicparse/cmd/panic/internal/ùtf8/ùtf8.go",
RelSrcPath: "github.com/maruel/panicparse/cmd/panic/internal/ùtf8/ùtf8.go",
s: "/gpremote/src/github.com/maruel/panicparse/cmd/panic/internal/ùtf8/utf8.go",
DirSrc: pathJoin("ùtf8", "utf8.go"),
SrcName: "utf8.go",
LocalSrcPath: "/gplocal/src/github.com/maruel/panicparse/cmd/panic/internal/ùtf8/utf8.go",
RelSrcPath: "github.com/maruel/panicparse/cmd/panic/internal/ùtf8/utf8.go",
ImportPath: "github.com/maruel/panicparse/cmd/panic/internal/ùtf8",
Location: GOPATH,
},
Expand Down