fix: expose types in export map #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `nodenext` resolution in typescript, the compiler will not fall back to top-level `types` and will instead expect there to be a sibling `d.ts` file or a `types` entry in the export. This means currently errorstacks fails builds in modern typescript setups. This fix introduces a `types` entry for the export, which points at the same definition file as the top-level `types`.
|
@marvinhagemeister have updated it 👍 |
|
@marvinhagemeister any chance you could publish a new version? would be good to unblock some work i have depending on this 🙏 |
+1 on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
nodenextresolution in typescript, the compiler will not fall back to top-leveltypesand will instead expect there to be a siblingd.tsfile or atypesentry in the export.This means currently errorstacks fails builds in modern typescript setups.
This fix introduces a
typesentry for the export, which points at the same definition file as the top-leveltypes.You can read more about that via this tool:
https://arethetypeswrong.github.io/?p=errorstacks%402.4.0