improve github asset detection #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, repos include a corresponding sha256 file for each release asset (such as in https://github.com/dominikh/go-tools/releases). For the purposes of asset detection it can cause the user to have to unnecessarily select the asset manually because the regex doesn't make a distinction between
staticcheck_darwin_arm64.tar.gz.sha256and
staticcheck_darwin_arm64.tar.gzThis PR just filters out files that end in
.sha256so that stew is more likely to automatically detect the appropriate release asset for the user.