maryia/79969/feat: disable all chart modes besides 'Area' and '1 tick' interval #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
changed the title
maryia-deriv
pushed a commit
that referenced
this pull request
Nov 28, 2022
…#5831) * added verified modal component * feat: incorporated welcome modal * fix: integrated new user flow * added styles to modal risk tolerance warning and cooldown warninig * change border bottom stylings * code cleanup * fix cooldown warning modal styling and added to handleondecline * feat: redirect user to POI * remove margin at the bottom for risk tolerance modal * added trading experience modal, ic-eu-check icon and fix stylings for verified account modal * added completed assessment modal for existing user trading assessment flow * feat: integrated new user flow with API * minified svg * fix: incorporated error modals * ref: Code refactor * fix: Added Cool down modal * fix: removed console statements * ref: API request update * replace icon in complete assessment modal with IcCheckmarkCircle * ref: removed commented code * remove ic-verification-success icon from icons.js * removed icon * feat: Added logic to display cooldown modal * test: verified functionality of new MF flow * feat: incorporated welcome modal * removed consoles * feat: Integrated exisitng user flow * feat: integrated exisiting user flow * Added todos * readded ic verification success to modal * change function of risk tolerance modal and added displayNextPage * feat: incorporated existing user flow * ref: Code refactor in assessment form * fix: Responsive CSS styles * fix: lint errors * fix: precommit file * code refactor * added stylings for responsive for mf new users signup * ref: Modified the payload structure to be in sync with BE * resolved: remove isMobile inside of risk-tolerance-modal * resolved: remove isMobile inside of risk-tolerance-modal * fix: Modified API call for Financial assessment section for All users * fix dropdown option select issue * resolved review comments * reverted changes * fix button in test modal for mobile view * fix: account switcher * feat: Move to next question * fix: reverted css removal * fix resolve issues: added .jsx, rename components for dropdown and radio, change logic for enabling next section and remove comments * remove es-lint * resolved duplicated keys in accordion.jsx and autocomplete.jsx * resolved: change units from px to rem * changed units from px to rem account-wizard.scss * resolved: logic at trading-assessment-dropdown, shorten name in ui-store * added new assessment section in profile settings * fix: remove trading assessment from appstore * added questions onto the settings page * added trading-assessment form and stylings to both desktop and mobile * feat: incorporated disable-withdrawal-modal * feat: incorporated notification * feat: re-ordered the notification list * feat: incorporated withdrawal disable for desktop * feat: incorporated notification for mobile * fix: added stylings as per figma * added functionalities to the form including submit functionalities aswell as modals * fix issues: initial value not shownfor some fieldset * added trading assessment into webpack and add changes to trading assessment * Refactored Trade assessment code (#23) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * Feat new flow mf account (#24) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * Feat: added disable checks for assessments (#25) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: incorporated notification (#26) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * changed the modal text (#27) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * added reinitialize * edit dropdown component and remove useeffect focus * Fixed risk client check (#28) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * Feat new flow mf account (#29) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * added financial assessment banner for high risk clients aswell as normalize values for financial-assessment * remove commented line * remove trading experience section from view for mf clients * added is_risk_client into banner conditions and fix client store error * remove is_risk_client into banner conditions * Empty-Commit * Syncing with upstream (#30) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * resolved comments in: trading-assessment-config, select-native, trading-assessment-existing-user, trading-experience-modal,account-wizard, real-account-signup,account-wizard and client-store. * Feat new flow mf account (#31) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * added setFinancialAndTradingAssessment inside of client-store * added loading screen component to trading-assessment * Feat new flow mf account (#32) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * replaced is_svg with is_mf in financial-assessment.jsx * fix logic banner on financial-assessment and added cfd score inside of client-store * Feat new flow mf account (#33) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix: added missing store * fix: status * Feat new flow mf account (#34) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix bug (binary-com#6154) * yauheni/ 70488/ edit note in self-exclusion message box (binary-com#6044) * text|edit_note_self_exclusion_message_box * test fix * regexp in tests fix * accident text deleted * popup message text fix * text fixes * test text query fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Akmal / Ignore IDV verification if client is high risk && withdrawals are locked (binary-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered * fix:tax_number_validation (binary-com#6259) * george / rm65047 / convert routes, cashier, error-component components to TS (binary-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense * george / rm65033 / ts migration of withdraw UI components (binary-com#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests * update deriv go redirection link (binary-com#6386) * Farzin/68320/Update cashier withdrawal locked status if PA already withdraw all his allowable withdrawal amount (binary-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build * Jim/73479/appstore-workspace-ts-fix (binary-com#6208) * chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export * Niloofar Sadeghi / Trader Typescript configuration issue (binary-com#6275) * fix: trader typscript configuration issue * fix: tsc errors on trader * Niloofar Sadeghi / Add typescript configuration on reports (binary-com#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages * george / rm65041 / migrate p2p-cashier component to TS (binary-com#6177) * refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables * Vinu/Ts onramp cashier (binary-com#5727) * refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (binary-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (binary-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (binary-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (binary-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (binary-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (binary-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> * hamid/65036/migrate-account-transfer-to-ts (binary-com#6305) * Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name * Niloofar Sadeghi / Account typscript configuration issue (binary-com#6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig * fix: added missing store * Niloofar Sadeghi / Circleci issue (binary-com#6402) * fix: circle ci issue * fix: circle ci issue * Niloofar Sadeghi / Add typescript to each workspace dependency (binary-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts * Shayan/74388/fix ts config on cfd (binary-com#6351) * checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config * translations: 📚 sync translations with crowdin (binary-com#6405) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: status Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix select-native placeholder prop and remove success modal from existing user TA settings page * disabled financial assessment submenu on mobile * change css for financial-banner on FA page * Feat new flow mf account (#35) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix bug (binary-com#6154) * yauheni/ 70488/ edit note in self-exclusion message box (binary-com#6044) * text|edit_note_self_exclusion_message_box * test fix * regexp in tests fix * accident text deleted * popup message text fix * text fixes * test text query fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Akmal / Ignore IDV verification if client is high risk && withdrawals are locked (binary-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered * fix:tax_number_validation (binary-com#6259) * george / rm65047 / convert routes, cashier, error-component components to TS (binary-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense * george / rm65033 / ts migration of withdraw UI components (binary-com#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests * update deriv go redirection link (binary-com#6386) * Farzin/68320/Update cashier withdrawal locked status if PA already withdraw all his allowable withdrawal amount (binary-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build * Jim/73479/appstore-workspace-ts-fix (binary-com#6208) * chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export * Niloofar Sadeghi / Trader Typescript configuration issue (binary-com#6275) * fix: trader typscript configuration issue * fix: tsc errors on trader * Niloofar Sadeghi / Add typescript configuration on reports (binary-com#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages * george / rm65041 / migrate p2p-cashier component to TS (binary-com#6177) * refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables * Vinu/Ts onramp cashier (binary-com#5727) * refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (binary-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (binary-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (binary-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (binary-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (binary-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (binary-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> * hamid/65036/migrate-account-transfer-to-ts (binary-com#6305) * Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name * Niloofar Sadeghi / Account typscript configuration issue (binary-com#6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig * fix: added missing store * Niloofar Sadeghi / Circleci issue (binary-com#6402) * fix: circle ci issue * fix: circle ci issue * Niloofar Sadeghi / Add typescript to each workspace dependency (binary-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts * Shayan/74388/fix ts config on cfd (binary-com#6351) * checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config * translations: 📚 sync translations with crowdin (binary-com#6405) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: status * hamid/75726/missing-grey-box-side-note (binary-com#6410) * Fix sidenote in mobile view of account-transfer * Remove duplicate title * Add sideNote title Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: failing test cases * addded success button for TA, change modal for TA, and add new state in ui store * remove footer message in mobile and fix scoll offset for both mobile and desktop in FA * fix warning modal behavior on TA * resolved: replaced { with ( in risk-tolerance-warning-modal.jsx, removed default props in mobile-dialog.jsx * resolved: refactor code at trading-assessmnet-form.jsx and financial-assessment.jsx * resolved: add setFinancialAndTradingAssessment in proptypes. * resolved: change background-color name * resolved: remove curly brackets and return statment and replaced with regular brackets. Remove size prop in Text * resolved: change conditions to not show financial assessment tab in mobile view * resolved: added is_trading_assessment_for_existing_user_enabled in Proptypes * fix: incorporated review comments * fix: incorporated review comments * resolved: added is_svg based on compliance requirements * resolved: replace with suggested stylings * resolved: updated hide placeholder prop inside of select native component * fix: localize issue * renamed the icon * refactor: ♻️ incorporated review comments * resolved: change position of text and value in config file * fix: 🎨 removed index based key for child elements * fix: fix typo in testwarning modal and remove duplicate modals in trading assessment * fix: remove banner after financial assessment change and remove notification from trading screen * fix: 🐛 incorrect display of notification * fix: refactor warning modal in trading-assessment * resolved: change component key * resolved: change is_risk_client --> is_risky_client based on comment * fix: circle ci fail test * feat: ✨ moved employment field to personal details incase of MF clients * Revert "likhith/moved employment field to personal details incase of MF clients" (#37) * likhith/moved employment status field (#38) * feat: ✨ moved employment status field * Create CNAME * Delete CNAME * feat: 💄 added style to highlight next section button * perf: 💄 incorporated fied changes * feat: 🐛 title case * feat: 🔥 removed unwanted state * feat: ♻️ reverted code changes of diff package * feat: 🐛 added key prop to iterating component * fix: 🐛 removed decorators * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * feat: ♻️ removed extensions * feat: ♻️ incorporated review comments * feat: ♻️ Added comments to explain code logic * feat: ♻️ reordered imports * feat: ♻️ incorporated styling changes * feat: 🐛 navigate the user to next question * feat: 🐛 resolved logout error * fix: add warning icon to cooldown warning modal * fix: display correct cool down modal for new client signup * feat: 🐛 missing warning when trading assessment values are changed * fix: submit button not triggered in mozilla * fix: 🚑 logic fix to trigger click event in mozilla * fix: resolve memory leak for risk modal * fix: move employment fieldset at the bottom * fix: added space to remove overlapping text on fieldset * fix: 🎨 reused component * fix: 🎨 reused component * fix: next and previous button fix * fix: change employement status field in personal details page * ci: fix circle ci issues Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: System Administrator <root@Likhith-Kolayaris-MacBook-Pro-C02G8AT9MD6M.local>
maryia-deriv
pushed a commit
that referenced
this pull request
May 17, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
maryia-deriv
pushed a commit
that referenced
this pull request
Jun 5, 2023
* feat: evgeniy-wall-376/likhith-wall-379/ onfido and idv verification ux improvement with example * refactor: example window styles and types improvvements * fix: circlci test error * chore: formik init * feat: ✨ incorporated IDV in Personal details for Real account sign up * feat: 🐛 resolved failing tests * chore: api updating form and styles * feat: accounts settings identity onfido impovements add * refactor: ♻️ incorporated review comments * fix: text content * feat: 🎨 migrated to TSx * feat: upgraded pack * refactor: inputs form in separate components * chore: example form ts * chore: example container ts * refactor: ts fix * chore: props passing data instead of connect * feat: 🎨 refactor stylings of shared component * feat: incorporated shared component into poi * feat: incorporated shared component into poi * fix: styles, unnecessary code remove * fix: styles for onfido * chore: fix styling * fix: lost styles restore * style: 🎨 resolved issue with onfido container for mobile * feat: 🎨 incorporated IDV new flow * chore: styles onfido * fix: 🐛 resolved tooltip issue * chore: css onfido page * feat: 🎨 incorporated testcases * fix: 🐛 resolved incorrect path * fix: 🐛 failing test case * chore: new confirm form tests * chore: onfido-sdk-view ts migration * chore: deeprequired type fix * Likhith/hide helper image on no avbl doc (#9) * style: 🎨 incorporated hiding of helper image based on avbl doc * style: 🎨 moved color to common variable * Shahzaib/kyc 42/success banner design updates (#10) * style: update positioning of success banner in KYC flow * style: update positioning of success banner in mt5 account flow * chore: renamed prop from is_mt5 to is_external * style: status message width * Likhith/kyc-34/ improve idv flow for poi (#11) * feat: 🎨 incorporated new changes * feat: ✨ incorporated idv for mt5 * refactor: review comments implementation * fix: ⚡ resolved code smells * fix: ⚡ resolved failing testcase * fix: ⚡ removed commented lines * fix: ⚡ removed minor code smells * fix: ⚡ removed minor code smells * feat: 🎨 code refactored * refactor: onfido window separate component * feat: 🎨 code refactored * feat: 🎨 code refactored (#16) * feat: 🐛 minor code smells * chore: error message banner for onfido flow * chore: renamed error message field name * Revert "Merge branch 'master' of https://github.com/binary-com/deriv-app into shahzaib/KYC-1/error-handling-for-onfido-flow" This reverts commit 44635a3, reversing changes made to f5b8fb9. * refactor: sonar cloud security issue * fix: circleci issue * fix: 🐛 removed a code smell * feat: 🎨 added new testcase * feat: 🎨 removed duplicated types * feat: minor bug fix * chore: onfido sdl view test * chore: onfido types rename, timeout comment * feat: reverted localize changes * feat: incorporated review comments * fix: resolved placeholder * feat: resolved radio button issue * fix: minor bug fix * refactor: custom math random create * refactor: deep required * refactor: revert commits with api hooks * fix: 🚑 reverted the radio button change * fix: errors object with empty fields * fix: date picker update value * fix: 🎨 formatted the code * fix: 🎨 formatted the code * chore: added cleartime out * chore: added cleartime out * refactor: ♻️ incorporated review comments * fix: removed code smells * refactor: onfido blue hint box loading fix * chore: removed unnecessary formik field * fix: 🚀 incorporated null checks * chore: resolved prop duplication in form fields * chore: updated name and types in idv form fields * chore: removed unnecessary formik field * fix: add name prop to date of birth custom component (#23) * Refactor/form fields (#24) * fix: add name prop to date of birth custom component * fix: test cases * refactor: update props from formik for date custom fields component * fix: personal-details import image error * fix: ♻️ incorporated review comments * fix: 🐛 build path issue * feat: removed unused import * style: poi form (#25) * fix: 🎨 fixed styling issue * fix: 🐛 import fix * refactor: is_external flag onfido remove * chore: fix render glitch in mt5 form (#29) * chore: fix render glitch in mt5 form * fix: dispose onfido_ref if any error occurs during onfido token fetching or sdk initialization * fix: add a check to display info message upon onfido initialization (cherry picked from commit 1cf15d2) * fix: asterisk in fields label * feat: 🐛 resolved the testcase issue * fix: empty line validation * feat: ✅ fix failing testcases * Likhith/kyc 95/document number reset (#30) * fix: 🐛 fix document number reset * fix: ✨ incorporated idv option fix * fix: 🐛 resolved the issue with DIEL * fix: fieldset padding in mobile screen (#31) * fix: css alignment form * fix: 🐛 resolved issue with tax field (#32) * fix: Place of birth issue * fix: 🐛 resolved issue with radio button (#33) --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com>
maryia-deriv
added a commit
that referenced
this pull request
Oct 11, 2023
* fix: ts-migrate trade-params * fix: sonarcloud * fix: pull in changes from tech debt 2 package * fix: resolve comments * fix: move type to common prop types * fix: move type to common prop types * fix: move type to common prop types file * fix: resolve comments * Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6) * refactor: migrate trade params and started mobile version * refactor: ts migration of trade params mobile * chore: add nessasary prop * refactor: apply suggestions * chore: change todo text * refactor: add import * fix: circleCI error * fix: ts migrate trade-footer-extensions.jsx * fix: fix import * fix: remove progress-slider-stream since its not used * fix: resolve comments * fix: reset with master * fix: reset with master * fix: reset with master * fix: reset with master * fix: circleCI * fix: togglePositions folder * fix: dtra-346 marketisclosed and marketcountdowntimer migration * fix: bug * Maryia/dtra-270/TS migration: trade-store (#5) * chore: prepare for migration * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: migrated trade-store to ts * chore: improve types in trade-store * fix: type * revert: hooks package installation * refactor: address review * fix: resolve comments * feat: add ts migartion of store * refactor: add prev changes * chore: empty commit * fix: add lost mocked * fix: resolve comments * Kate / DTRA-354 / Components/Form/Purchase files in Trader package (#21) * refactor: ts migartion of purchase files * refactor: remove duplicated types * refactor: apply suggestions * maryia/fix: sonarcloud warnings (#7) * fix: sonarcloud warnings * fix: Unexpected end of JSON input * fix: bug * fix: sonarcloud * fix: reorder props * fix: test cases * fix: coveralls * fix: coveralls * fix: this component doesnt exist anymore, hence test was also removed * henry/dtra-356/fix: ts-migration-digitsJSX (#24) * fix: initial commit * fix: ts migrate digits JSX * fix: small type change * fix: comment * chore: removed unused state * Maryia/dtra-355/Migrate ContractDrawer files to TS (#22) * feat: migrated swipeable-components to TS * feat: migrated market-closed-contract-overlay & index to TS * chore: migrated contract-drawer-card.tsx to ts * build: fix type * chore: migrated contract-drawer to ts * chore: fixed existing types in digits and logic * chore: sort types properties in alphabetical order * Kate/dtra 357/ts contract audit files (#23) * refactor: apply suggestion from prev pr * refactor: start ts migration of contract audit * chore: change comment * refactor: ts of contract audit item * refactor: ts migration of contract details * refactor: ts migration of contract history * refactor: add preprepared types * refactor: tests * chore: apply nit * refactor: apply suggestions * refactor: apply suggestions * chore: fix of sonar cloud * Maryia/dtra-373/remove localize from ContractCardHeader component (#25) * refactor: remove localize from contract-card-header * refactor: use Localize component instead of localize helper * build: install RTL deps in shared package * feat: merge previous tech debt branch * fix: sonar cloud codesmells * Merge branch kate/ts_migration_trader_package_4 into kate/ts_migration_trader_package_5 * Kate / DTRA-378 / TS migration: Multiplier components and containers in Trader package (#26) * refactor: ts of cancel deal and risk managment info * fix: types in dialog tsx * refactor: start ts of multiplier options * refactor: ts of mult amount modal * refactor: remove default val from basis component * fix: type of amount mobile * refactor: applied suggestions * refactor: ts of multiplier info (#28) * Henry/dtra 376/fix: ts migration positionsdrawer folder (#27) * fix: positions drawer folder * fix: coveralls * fix: where is my commit * fix: found commits * fix: file rename * fix: comments * fix: comments * fix: correct logic * fix: remove unused props * fix: types * refactor: remove code mells * fix: ts-migrate-populate header (#30) * Maryia/DTRA-377/TS migration: TradingDatePicker + TradingTimePicker + TimePicker + Dialog (#29) * chore: timepicker to ts * chore: trading timepicker to ts * chore: add types for TradingDatePicker & DatePicker * refactor: added default values * refactor: remove code small * chore: empty commit * fix: not using index as key (#31) * fix: ternary bug * fix: build TS errors (#32) * refactor: apply suggestions * refactor: change type of time * chore: empty commit * refactor: tests * fix: conflicts * fix: conflicts * fix: tests * fix: types in tests * fix: test extention * fix: add turbos to types back * fix: add backup for target name * fix: revert empty strings --------- Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change