Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users/creation): data limit default value shounld't be enforced and reset to 0 #601

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

Krr0ptioN
Copy link
Collaborator

Description

Resolving confusions and bugs around data limit.

UI Changes

  • Data limit field won't reset to 0, and the default value is undefined.

Screenshots

API Changes

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests (stories, interaction tests, unit tests, e2e tests) to cover my changes.
  • I have added tests to cover my changes.

Related Issues

Closes #587, #572

@Krr0ptioN Krr0ptioN added bug Something isn't working improvement Improving and harnessing the quality criteria of an already existing feature and implementation frontend labels Oct 23, 2024
@Krr0ptioN Krr0ptioN self-assigned this Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link

sonarcloud bot commented Oct 24, 2024

@Krr0ptioN Krr0ptioN merged commit e381b12 into master Oct 24, 2024
11 checks passed
@Krr0ptioN Krr0ptioN deleted the fix/572-usage-duration-0 branch October 24, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend improvement Improving and harnessing the quality criteria of an already existing feature and implementation
Projects
None yet
1 participant