Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix signout command, return error instead of crash from signin command #162

Merged
merged 17 commits into from
Aug 11, 2018

Conversation

phatblat
Copy link
Member

@phatblat phatblat commented Aug 11, 2018

This is not a fix for the root cause but prevents a crash whenever the signin command is used on newer versions of macOS (10.13+). Users running older macOS versions (10.9-10.12) are unaffected.

Resolves the crasher reported in #107. See #164 for more details.

@todo
Copy link

todo bot commented Aug 11, 2018

Handle failed AppleID lookup

} else {
// TODO: Handle failed AppleID lookup
print("No account found for username: \(username)")
}
group.leave()
}


This comment was generated by todo based on a TODO comment in 2518736 in #162. cc @mas-cli.

@phatblat phatblat mentioned this pull request Aug 11, 2018
@ldgmini
Copy link

ldgmini commented Aug 11, 2018

1 Warning
⚠️ 😵 Big PR

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants