Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆕 feat(InfiniteScroll): load next page if there is still space to load #2320

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

capdiem
Copy link
Contributor

@capdiem capdiem commented Feb 10, 2025

Resolves #2176

@capdiem capdiem requested a review from Copilot February 10, 2025 09:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 21 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • src/Masa.Blazor/wwwroot/css/masa-blazor.extend.css: Language not supported
  • src/Masa.Blazor/Components/InfiniteScroll/MInfiniteScroll.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/Color.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/CustomContent.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/Error.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/Manual.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/Usage.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/VirtualScroller.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/Examples/components/infinite-scroll/ChildContent.razor: Evaluated as low risk
  • docs/Masa.Blazor.Docs/wwwroot/pages/components/infinite-scroll/en-US.md: Evaluated as low risk
  • src/Masa.Blazor.JS/rollup.config.esm.ts: Evaluated as low risk
  • src/Masa.Blazor/wwwroot/js/masa-blazor.js: Evaluated as low risk
  • docs/Masa.Blazor.Docs/wwwroot/pages/components/infinite-scroll/zh-CN.md: Evaluated as low risk
  • src/Masa.Blazor.JS/src/main.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/Masa.Blazor.JS/src/components/infinite-scroll/index.ts:1

  • The 'element' parameter in the 'isWindow' function should have a more specific type than 'any'. Consider using 'unknown' or a more specific type.
import { isWindow } from "utils/helper";

src/Masa.Blazor/Components/InfiniteScroll/MInfiniteScroll.razor.cs:164

  • [nitpick] The parameter name 'abc' is not descriptive. It should be renamed to something meaningful like 'isScrolling'.
public async Task OnScrollInternal(bool abc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: MInfiniteScroll组件第一次渲染不触发OnLoad
1 participant