Code

Rewrite in Typescript: Spinner#317

Code

Closed

zaki-yama wants to merge 16 commits intotypescript-tree-nodemashmatrix/react-lightning-design-system:typescript-tree-nodefrom typescript-spinnermashmatrix/react-lightning-design-system:typescript-spinnerCopy head branch name to clipboard

+78-83

Commits

Commits on Jun 21, 2019

• #289 Spinner: mv .js -> .tsx

  zaki-yama

  committed
  23c9656

  Copy full SHA for 23c9656

• #289 Spinner: Convert propTypes to TypeScript types

  zaki-yama

  committed
  8a6fbc7

  Copy full SHA for 8a6fbc7

• #289 Spinner: mv story .js -> .tsx

  zaki-yama

  committed
  6c9a1f9

  Copy full SHA for 6c9a1f9

• #289 Spinner: Fix story's type errors

  zaki-yama

  committed
  b5a6aed

  Copy full SHA for b5a6aed

• #289 Spinner: Quit default export

  zaki-yama

  committed
  96d1acf

  Copy full SHA for 96d1acf

• #289 Spinner: Change initial value of size to "small"

  zaki-yama

  committed
  fd9d863

  Copy full SHA for fd9d863

• #289 Spinner: Add HTMLAttributes<HTMLDivElement> to props

  zaki-yama

  committed
  c26166e

  Copy full SHA for c26166e

Commits on Jun 27, 2019

• #289 Spinner: Stop using defaultProps

  zaki-yama

  committed
  6b7e29c

  Copy full SHA for 6b7e29c

Commits on Jul 1, 2019

• #289 Spinner: Handle empty string for size in story

  zaki-yama

  committed
  b438ac3

  Copy full SHA for b438ac3

• Revert "#289 Spinner: Handle empty string for size in story"

  Show description for c3959bf
  zaki-yama

  committed
  c3959bf

  Copy full SHA for c3959bf

• #289 Spinner: Add a comment about knobs

  zaki-yama

  committed
  7050890

  Copy full SHA for 7050890

Commits on Jul 2, 2019

• #289 Spinner: Fix type definition of props in constructor

  zaki-yama

  committed
  3929d3a

  Copy full SHA for 3929d3a

Commits on Jul 9, 2019

• #289 Spinner: Manually set type for destructuring assignment

  zaki-yama

  committed
  04ca3ef

  Copy full SHA for 04ca3ef

• #289 Spinner: SpnnerProps should contain HTMLAttributes

  zaki-yama

  committed
  495e358

  Copy full SHA for 495e358

• #289 Spinner: Workaround for passing undefined in story

  zaki-yama

  committed
  fee9dc2

  Copy full SHA for fee9dc2

• #289 HTMLAttributes should be included in its own props

  zaki-yama

  committed
  20f4ef8

  Copy full SHA for 20f4ef8