Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in Typescript: Icon #318

Closed
wants to merge 18 commits into from
Closed

Rewrite in Typescript: Icon #318

wants to merge 18 commits into from

Conversation

zaki-yama
Copy link
Collaborator

ref. #289

TODO: after #317 is merged, change base branch to 3.0

@zaki-yama zaki-yama self-assigned this Jun 23, 2019
@stomita stomita mentioned this pull request Jun 23, 2019
Closed
41 tasks
@zaki-yama zaki-yama mentioned this pull request Jul 6, 2019
Closed
zaki-yama added 17 commits July 8, 2019 23:58
@zaki-yama
#289 Icon: mv .js -> .tsx
1ceaac9
@zaki-yama
#289 Icon: Install @types/svg4everybody
4aff676
@zaki-yama
#289 Icon: Convert propTypes to TypeScript types
73728f5
@zaki-yama
#289 Icon: Add non-null assertion when passing icon props in Button…
426058f 
…Icon
@zaki-yama
#289 Icon: Avoid passing textColor={null} in ButtonIcon
becd1f8
@zaki-yama
#289 Icon: pointerEvents should not be included in style
e68bd88
@zaki-yama
#289 Icon: Fix type error of getComputedStyle
77f13f7
@zaki-yama
#289 Button: Change icon of ButtonIcon to required props
218d483
@zaki-yama
#289 Icon: HTMLAttributes is unused
893353b
@zaki-yama
#289 Icon: Accept null in textColor
3ab2940
@zaki-yama
#289 Icon: Update snapshot
230c7f5
@zaki-yama
#289 Icon: mv story .js -> .tsx
378b622
@zaki-yama
#289 Icon: Fix story type errors
ffac4b8
@zaki-yama
#289 Icon: Delete unnecessary eslint-disable comments
f91bd50
@zaki-yama
#289 Icon: mv test .js -> .tsx
d6c5492
@zaki-yama
#289 Icon: Install @types/power-assert
617903a
@zaki-yama
#289 Icon: Quit default export
581065a
@zaki-yama zaki-yama changed the base branch from typescript-spinner to 3.0 October 28, 2019 13:30
@zaki-yama zaki-yama changed the base branch from 3.0 to typescript-spinner October 28, 2019 13:31
@zaki-yama
Copy link
Collaborator Author

Closed because the last PR #342 had been merged.

@zaki-yama zaki-yama closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zaki-yama zaki-yama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zaki-yama