[#128] Make case comparisons consistent between various locale settin… #255
Conversation
… setting methods (e.g. cookies, headers, query).
|
In the existing code line, the behavior is a bit different when using queryParameters to set locale in the case of a language code like en-US. if setting via: After reading it a few times, I suspect this is a bug, but have wrapped it in a config value just in case some current users rely on this behavior. |
| @@ -2,7 +2,7 @@ var i18n = require('../i18n'), | |||
| should = require("should"), | |||
| path = require("path"); | |||
|
|
|||
| describe('Locale switching should work queryParameter', function() { | |||
| describe('Locale switching should work when set via cookie', function() { | |||
There was a problem hiding this comment.
Not really related to this change set, but seemed polite to clean this up.
There was a problem hiding this comment.
yap I've seen this... thanks again - I bet there are still some more typos in readme, comments & tests - 6 years of part time maintenance...
|
Thank you sir! It'd be best to handle those consistent internally. Refactoring such is still on my backlog, so your help catching up is much appreciated. I will review some extra changes on weekend to merge and publish. |
|
Ok thanks, let me know if you'd prefer I pull out the config switch, and just fix it as a bug. |
|
the switch is fine - I am a big fan of feature switches and legacy switches could help with issues until next major release. |
…g methods (e.g. cookies, headers, query).