-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed deprecated messageformat #472
Conversation
@mashpie There might be breaking changes for a few people (as the validation for unused plural keys was disabled by default): Line 332 in 494a464
PRs explaining the reasons: messageformat/messageformat#244 cc @eemeli |
Thanks @calmonr for your effort. I‘ll take some time to review those breaking changes carefully - would be the 1st break in 10 years;) |
I should try to keep test cases with real mf strings in json files, Russian for example plurals are complex and should still work. |
@mashpie I just sponsored you on GitHub - hopefully you can get this resolved so we can no longer have the dep warning! |
@niftylettuce ! Thank you so much :) |
Of course @mashpie, without this project, https://forwardemail.net wouldn't have localization! |
This is a nice testimonial! Note to myself: … should collect them. |
@calmonr Thanks for PR https://github.com/mashpie/i18n-node/releases/tag/0.14.0
|
@mashpie You're most welcome. |
The package
messageformat
has been deprecated in favor of@messageformat/core
.