Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_next_block_best_parents method in gRPC API #3419

Closed
aoudiamoncef opened this issue Jan 16, 2023 · 1 comment · Fixed by #3674
Closed

Implement get_next_block_best_parents method in gRPC API #3419

aoudiamoncef opened this issue Jan 16, 2023 · 1 comment · Fixed by #3674
Assignees
@modship
Labels
api Issues related to the API enhancement New feature or request need spec This issue need more specification

Comments

@aoudiamoncef
Copy link
Contributor

aoudiamoncef commented Jan 16, 2023 •
edited
Loading

This method will be a part of the new gRPC API as it's needed to be used primarily in newer Massa architecture.

Related to #3406 #2895 #2903
@aoudiamoncef aoudiamoncef mentioned this issue Jan 16, 2023
Closed
41 tasks
@aoudiamoncef aoudiamoncef changed the title get_best_parents Add get_best_parents method to JsonRPC API Jan 16, 2023
@aoudiamoncef aoudiamoncef added enhancement New feature or request api Issues related to the API need spec This issue need more specification labels Jan 16, 2023
@aoudiamoncef aoudiamoncef changed the title Add get_best_parents method to JsonRPC API Add get_best_parents method to JsonRPC API(V2) Jan 16, 2023
@aoudiamoncef aoudiamoncef changed the title Add get_best_parents method to JsonRPC API(V2) Add get_best_parents method Jan 16, 2023
@aoudiamoncef aoudiamoncef changed the title Add get_best_parents method Implement get_best_parents method Jan 16, 2023
@modship modship mentioned this issue Jan 20, 2023
Merged
7 tasks
@aoudiamoncef aoudiamoncef changed the title Implement get_best_parents method Implement get_next_block_best_parents method Jan 30, 2023
@aoudiamoncef aoudiamoncef changed the title Implement get_next_block_best_parents method Implement get_next_block_best_parents method in gRPC API Feb 21, 2023
@aoudiamoncef aoudiamoncef added p1 and removed wip labels Feb 21, 2023
@aoudiamoncef
Copy link
Contributor Author

@modship, this method should be moved to the gRPC module.

@AurelienFT AurelienFT removed the p1 label Feb 21, 2023
@modship modship self-assigned this Mar 10, 2023
This was referenced Mar 10, 2023
Merged
Merged
@modship modship linked a pull request Mar 10, 2023 that will close this issue
feat(grpc) : impl get_next_block_best_parents #3674
Merged
7 tasks
@modship modship closed this as completed Mar 13, 2023
@modship modship reopened this Mar 16, 2023
aoudiamoncef added a commit that referenced this issue Apr 4, 2023
@aoudiamoncef
Support Protobuf and gRPC (#3443)
9a93440 
Co-authored-by: modship <lu@massa.net>

closes #3600 #3420 #3423 #3652 #3621 #3421 #3419 #3426 #3491 #3422 #3406 #3448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@modship modship

Labels
api Issues related to the API enhancement New feature or request need spec This issue need more specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(grpc) : impl get_next_block_best_parents massalabs/massa
3 participants
@modship @aoudiamoncef @AurelienFT