Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sha256_hash ABI #3498

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Add sha256_hash ABI #3498

merged 7 commits into from
Feb 14, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Feb 3, 2023

  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

closes #3491

@aoudiamoncef aoudiamoncef changed the title Init testnet 20 Add sha256_hash ABI Feb 3, 2023
@aoudiamoncef aoudiamoncef force-pushed the feature/add-sha256-abi branch from 405b53b to 3d22dee Compare February 13, 2023 13:48
@aoudiamoncef aoudiamoncef marked this pull request as ready for review February 13, 2023 13:49
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this two clippy lints ? https://github.com/massalabs/massa/actions/runs/4173498451/jobs/7226016090 and we are good to go for merging !

@aoudiamoncef
Copy link
Contributor Author

Can you fix this two clippy lints ? massalabs/massa/actions/runs/4173498451/jobs/7226016090 and we are good to go for merging !

I dont have any clippy smells with: rustc 1.69.0-nightly (e972bc808 2023-01-29) && clippy 0.1.69 (e972bc80 2023-01-29)

@aoudiamoncef
Copy link
Contributor Author

@AurelienFT it's valentine gift 💟 . the toolchain is up to date.

Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

@aoudiamoncef aoudiamoncef force-pushed the feature/add-sha256-abi branch from d941ad0 to 44c85a4 Compare February 14, 2023 15:07
@aoudiamoncef aoudiamoncef force-pushed the feature/add-sha256-abi branch from 44c85a4 to 121432f Compare February 14, 2023 15:30
@aoudiamoncef aoudiamoncef merged commit 8809837 into testnet_20 Feb 14, 2023
@aoudiamoncef aoudiamoncef deleted the feature/add-sha256-abi branch February 14, 2023 16:32
Leo-Besancon pushed a commit that referenced this pull request Feb 22, 2023
Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
bors bot added a commit that referenced this pull request Mar 1, 2023
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Co-authored-by: Ben PHL <benphawke@gmail.com>
Co-authored-by: Modship <yeskinokay@gmail.com>
Co-authored-by: Ben <benphawke@gmail.com>
Co-authored-by: Eitu33 <89928840+Eitu33@users.noreply.github.com>
Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: modship <lu@massa.net>
Co-authored-by: Moncef AOUDIA <22281426+aoudiamoncef@users.noreply.github.com>
Co-authored-by: Moncef AOUDIA <ma@massa.net>
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants