Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grpc): implement subscribe_new_operations with filter #3690

Merged
merged 5 commits into from
Mar 17, 2023
Merged

feat(grpc): implement subscribe_new_operations with filter #3690

merged 5 commits into from
Mar 17, 2023

Conversation

modship
Copy link
Member

@modship modship commented Mar 16, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

User can filter his stream with one or more OperationType (Transaction, RollBuy, RollSell, ExecuteSC, CallSC)

TODO :

  • stream ExecuteSC operation
  • stream CallSC operation

close #3422

@modship modship linked an issue Mar 16, 2023 that may be closed by this pull request
Implement get_executed_operations method #3422
Closed
@modship modship marked this pull request as ready for review March 17, 2023 09:40
@modship modship merged commit 557e995 into feature/testnet-19-grpc Mar 17, 2023
aoudiamoncef pushed a commit that referenced this pull request Mar 28, 2023
@modship @aoudiamoncef
feat(grpc): implement subscribe_new_operations with filter (#3690)
5e35f7f 
* feat(grpc): implement subscribe_new_operations with filter

* feat(grpc): implement subscribe_new_operations for CallSC

* feat(grpc): implement subscribe_new_operations for ExecuteSC

* feat(grpc): remove dbg!

* feat(grpc): create service.rs and test mod
@AurelienFT AurelienFT deleted the feat/grpc_implement_subscribe_new_ope branch May 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement get_executed_operations method
1 participant
@modship