New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert checksum #4577

Merged

damip merged 1 commit into main from fix_cd

Nov 30, 2023

Contributor

Leo-Besancon commented Nov 30, 2023

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          Update cd.yml

668be92

Leo-Besancon requested a review from aoudiamoncef

November 30, 2023 16:23

aoudiamoncef approved these changes

View reviewed changes

aoudiamoncef approved these changes

View reviewed changes

Leo-Besancon requested a review from damip

November 30, 2023 16:26

damip approved these changes

View reviewed changes

damip merged commit 3d4e6f2 into main

10 checks passed

Leo-Besancon deleted the fix_cd branch

November 30, 2023 16:34

Leo-Besancon added a commit that referenced this pull request


          Update cd.yml (#4577)

8fcb3df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet