Add checksum for release archives #4590

aoudiamoncef · 2023-12-13T16:58:11Z

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Tested locally with ACT

codecov · 2023-12-13T17:26:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fd8f43) 71.78% compared to head (03681fc) 71.78%.

Additional details and impacted files

@@              Coverage Diff               @@
##           test_27_6_wip    #4590   +/-   ##
==============================================
  Coverage          71.78%   71.78%           
==============================================
  Files                291      291           
  Lines              51642    51642           
==============================================
  Hits               37069    37069           
  Misses             14573    14573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Leo-Besancon

If it has been tested locally I think it's a good idea to add this to the next release!

* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>

This reverts commit 49257e8.

* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>

This reverts commit 49257e8.

* Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net>

* Add initial chain id impl * Add chain id to jsonrpc, grpc public & grpc private api * Add massa-client features sandbox * Add chain id SC unit test * Fix unit test + add dummy gas costs * Update massa-proto-rs dependency * Update massa-sc-runtime dependency * Add unit test allowing easy update of massa docs * Use chain id through config instead of constants directly * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <sydhds@gmail.com> * Remove confusing chain id * Fix some unit tests * Test 27 6 wip (#4582) * Update addresses and public keys * Add more info to double staking protection's panic message * fmt * update version and genesis * Update version and CI * Update Cargo.lock * add community charter * Add serde json tests (#4579) * chore: typo fix (#4589) * Update to wasmer 4.2.4 (#4581) Co-authored-by: sydhds <sydhds@gmail.com> * typo fix * typo fix * typo fix * typo fix * typo fix --------- Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> * ci: add checksum + tested with ACT (#4590) * Upgrade-to-latest-toolchain (#4585) Co-authored-by: Leo-Besancon <lb@massa.net> * Update massa-sc-runtime Signed-off-by: Jean-François <jfm@laposte.net> * Cargo update * Remove compatibility layer in tracing (#4535) * Add deferred_credits initial file for test * Update Genesis and CI * Push back Genesis * Same --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Sydhds <sylvain.delhomme@gmail.com> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Jean-François <jfm@laposte.net> * Add initial chain id impl * Use chain id everywhere (round 1) (#4594) * Use chain id everywhere (round 1) * Use chain id in massa client --------- Co-authored-by: sydhds <sydhds@gmail.com> * Fix unit tests (final round) * Minor fix * Revert some nasty insert from bad rebase * Auto gen chain id from VERSION * Cargo clippy && fmt && doc pass * Update massa-sc-runtime dependency --------- Signed-off-by: Jean-François <jfm@laposte.net> Co-authored-by: sydhds <sydhds@gmail.com> Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Moncef AOUDIA <ma@massa.net> Co-authored-by: Ursulafe <152976968+Ursulafe@users.noreply.github.com> Co-authored-by: Jean-François <jfm@laposte.net>

ci: add checksum + tested with ACT

03681fc

aoudiamoncef requested a review from damip December 13, 2023 16:58

Leo-Besancon approved these changes Dec 14, 2023

View reviewed changes

aoudiamoncef merged commit 49257e8 into test_27_6_wip Dec 14, 2023
12 checks passed

Leo-Besancon linked an issue Dec 15, 2023 that may be closed by this pull request

Generate checksums for release files #4440

Closed

Leo-Besancon added a commit that referenced this pull request Dec 15, 2023

Revert "ci: add checksum + tested with ACT (#4590)"

394b72b

This reverts commit 49257e8.

damip pushed a commit that referenced this pull request Dec 15, 2023

Revert "ci: add checksum + tested with ACT (#4590)" (#4595)

86fa044

This reverts commit 49257e8.

sydhds pushed a commit that referenced this pull request Dec 20, 2023

Revert "ci: add checksum + tested with ACT (#4590)" (#4595)

0be997d

This reverts commit 49257e8.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add checksum for release archives #4590

Add checksum for release archives #4590

aoudiamoncef commented Dec 13, 2023 •

edited

Loading

codecov bot commented Dec 13, 2023

Leo-Besancon left a comment

Add checksum for release archives #4590

Add checksum for release archives #4590

Conversation

aoudiamoncef commented Dec 13, 2023 • edited Loading

codecov bot commented Dec 13, 2023

Codecov Report

Leo-Besancon left a comment

Choose a reason for hiding this comment

aoudiamoncef commented Dec 13, 2023 •

edited

Loading