Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross OS checksums #4596

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Add cross OS checksums #4596

merged 3 commits into from
Apr 2, 2024

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Dec 15, 2023

  • no breaking changes
  • could fail by nature and not affect the release process
  • could be simply relaunched
  • uses Github artifacts
  • uses official upload/download Github Actions
  • tested locally (scripts)
  • tested on a tweaked fork of massa

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (df156f3) to head (17c6321).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4596   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienFT
Copy link
Contributor

@Leo-Besancon can you check if it ok for you also ?

@Leo-Besancon
Copy link
Contributor

Leo-Besancon commented Apr 2, 2024

Hi @AurelienFT , for me it was ok yes (tested on a fork).
Even if as much as possible was done to test this, not sure if we want to risk having a failed CD release though.

@AurelienFT
Copy link
Contributor

Hi @AurelienFT , for me it was ok yes (tested on a fork). Even if as much as possible was done to test this, not sure if we want to risk having a failed CD release though.

If we tested it, then it should be okay + if the CD fail we just revert this PR it will not slow down us a lot compare to the whole time it takes to set up and launch a release

@AurelienFT AurelienFT added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 9df5bb4 Apr 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants