Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainnet genesis #4612

Merged
merged 23 commits into from
Jan 5, 2024
Merged

Mainnet genesis #4612

merged 23 commits into from
Jan 5, 2024

Conversation

Leo-Besancon
Copy link
Contributor

@Leo-Besancon Leo-Besancon commented Jan 4, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

TODO:

  • Add initial files
    • deferred_credits (/!\ no longer from submodule)
    • initial_ledger (/!\ no longer from submodule)
    • initial_rolls (/!\ no longer from submodule)
    • initial_peers
    • bootstrap whitelist
  • Settle the Version
    • Node Version constant, currently MAIN.1.0
    • Package versions, currently 1.1.0, but should probably be 1.0.0
  • Make sure the initial files are up to date and final!
  • Check the pre-genesis warning and maybe panics ? for absence of pre-genesis network communication

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d9ed3be) 71.78% compared to head (ea9266f) 71.78%.

Files Patch % Lines
massa-models/src/config/constants.rs 0.00% 1 Missing ⚠️
massa-xtask/src/update_package_versions.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4612   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo-Besancon Leo-Besancon marked this pull request as ready for review January 4, 2024 16:45
README.md Outdated Show resolved Hide resolved
damip and others added 3 commits January 5, 2024 09:56
Co-authored-by: AurelienFT <32803821+AurelienFT@users.noreply.github.com>
@Leo-Besancon Leo-Besancon added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 4563909 Jan 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants