Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown link checker action #4687

Merged
merged 2 commits into from
May 21, 2024
Merged

Add markdown link checker action #4687

merged 2 commits into from
May 21, 2024

Conversation

m4ns0ur
Copy link
Contributor

@m4ns0ur m4ns0ur commented May 6, 2024

Similar to link checker action in Massa docs: https://github.com/massalabs/docs/pull/157/files/d3499d290c95240b4720aea10c3e32a2bd20b903
Fixes: #3586

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT AurelienFT enabled auto-merge May 21, 2024 09:38
@AurelienFT AurelienFT added this pull request to the merge queue May 21, 2024
Merged via the queue into massalabs:main with commit 63ba310 May 21, 2024
10 of 11 checks passed
@m4ns0ur m4ns0ur deleted the add-link-checker-action branch May 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is some github actions to auto check for dead links
2 participants
@m4ns0ur @AurelienFT