Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollback to mainnet config and Change two constants to config and add pruning block storing #4697

Merged
merged 3 commits into from
May 29, 2024
Merged

rollback to mainnet config and Change two constants to config and add pruning block storing #4697

merged 3 commits into from
May 29, 2024

Conversation

AurelienFT
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT AurelienFT changed the title change two constants to config and add pruning block storing rollback to mainnet config and Change two constants to config and add pruning block storing May 29, 2024
Leo-Besancon
Leo-Besancon approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AurelienFT AurelienFT mentioned this pull request May 29, 2024
Open
@AurelienFT AurelienFT added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 18119d4 May 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet left review comments

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @bilboquet @Leo-Besancon