Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-31955 Check for empty items for suggested pages #1886

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

ygannett
Copy link
Contributor

@ygannett ygannett commented Feb 27, 2024

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

Add a condition to check li items and set not to generate ul when no item.
No visual change.

Related Issue / Ticket

Steps to Test

  1. Test with guide page by removing suggested page items to see if ul is generated in inspect.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

@todo

Today I learned...

@arthurbaghdas arthurbaghdas merged commit b606dd4 into develop Feb 28, 2024
5 checks passed
@arthurbaghdas arthurbaghdas deleted the patternlab/DP-31955_suggested-pages branch February 28, 2024 07:01
@clairesunstudio clairesunstudio mentioned this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants