Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too easy to trigger column swiping #4035

Closed
1 of 2 tasks
sorin-davidoi opened this issue Jul 2, 2017 · 7 comments · May be fixed by ericblade/mastodon#3
Closed
1 of 2 tasks

Too easy to trigger column swiping #4035

sorin-davidoi opened this issue Jul 2, 2017 · 7 comments · May be fixed by ericblade/mastodon#3

Comments

@sorin-davidoi
Copy link
Contributor

I find myself accidentally swiping columns when scrolling up / down. react-swipeable has a delta which configures how long the swipe has to be before it is considered a swipe. The default is 10px.

This issue is mostly to see if this affects other people. We can increase the delta if this is the case.


  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
  • This bug happens on a tagged release and not on master (If you're a user, don't worry about this).
@kyzh
Copy link

kyzh commented Jul 2, 2017

I have an issue that sounds exactly like what you describe here.
It is really frustrating to say the least and I'm glad this could be the answer to it.

When I was trying to put words on what I was experiencing, I found 2 main behaviours:

  • going laterally column wise
  • the change to happen at content/column level before the top icon.

I actively tried to swipe and the column content change before the icon at the top show the focus.
I therefore think my issue and yours is the same.

Speaking for myself, I'd love to be able to disable swiping all together as it is slower and less practical than clicking the icon at the top.
It take longer than clicking the icon at top (by an order of magnitude I'd say)

@sorin-davidoi
Copy link
Contributor Author

We are working on making swiping columns faster - it is indeed annoying that the content and the icon at the top are not in sync for ~1 second. Thanks for commenting, will make a pull request to increase the delta - 25 / 30 pixels should do it.

@sorin-davidoi
Copy link
Contributor Author

Regarding disabling it, this was a highly requested feature, we just need to make sure it is not triggered by accident.

@nightpool
Copy link
Member

I think the bigger issue here is the lack of visual feedback. It's impossible to tell when you MIGHT be triggering a swipe, so it ends up coming out of nowhere when it does happen.

@jalefkowit
Copy link

I'm not sure why this issue has been closed; I still run into accidental column changes via swipe all the time on multiple devices (iPad Air 2 in Safari, Galaxy S6 in Firefox). Despite my going out of my way to try and keep my scrolling gestures perfectly vertical, it happens frequently enough to make the mobile web version of Mastodon unusable.

@nightpool
Copy link
Member

@jalefkowit These problems were fixed in the upcoming version of Mastodon, which isn't out to most instances yet. What version is your instance using?

@jalefkowit
Copy link

@nightpool I'm on octodon.social, which as of this writing is running 1.4.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants