Improve swipe experience #12168
Merged
Improve swipe experience #12168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Oct 15, 2019
|
Well, GitHub shows waiting for CI status forever... |
aji-su
pushed a commit
to aji-su/mastodon
that referenced
this pull request
Oct 24, 2019
cherry-picking commit f4be89e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the swipe is too sensitive on mobile devices. Related issues: #4038 and #4035.
The
react-swipeable-viewschanged a lot since 2017 so the previous commit no longer works.Changes:
threshold={15}sets the speed threshold to be three times less sensitive than default to be identified as a quick-swipe. The default value is 5, which is too sensitive according users' feedback.hysteresis={0.2}sets the delta threshold to be 20% of width to swipe for a slow swipe. By default this value is 0.6, which means users have to swipe 60% of the width to switch to another page during slow-swipes. The default value does not make sense.I have tested these values and saw no side-effect.
Reference:
[1]
react-swipeable-viewsAPI document: https://react-swipeable-views.com/api/api/