Do not misattribute inlined boosts if attributedTo isn't present
#10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'm not 100% sure it is what caused the mentioned issue, as the example mentioned in the issue should not cause that. But it's the only code path I can see that uses the boosters' account when processing the boosted toot. |
Gargron
approved these changes
Jun 4, 2019
ClearlyClaire
force-pushed
the
fixes/announce-inlined-misattribution
branch
from
a55b1c2
to
38c067f
Compare
ClearlyClaire
force-pushed
the
fixes/announce-inlined-misattribution
branch
from
38c067f
to
f7c7d80
Compare
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…astodon#10967) * Do not misattribute inlined boosts if `attributedTo` isn't present Fixes mastodon#10950 * Fix tests
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jan 7, 2021
…astodon#10967) * Do not misattribute inlined boosts if `attributedTo` isn't present Fixes mastodon#10950 * Fix tests
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
…astodon#10967) * Do not misattribute inlined boosts if `attributedTo` isn't present Fixes mastodon#10950 * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10950
As of 6a5307a, we accept boosts of inlined toots provided that they can be attributed to the actor boosting it. However, we assume that if no
attributedTofield is present, then the object is to be attributed to the actor boosting it.I guess that assumption might not be correct, although cases where that assumption would not be correct are cases where we cannot attribute the toot at all.