Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page body not being scrollable in admin layout #11893

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Sep 19, 2019

Hide navigation behind hamburger icon on small screens in admin layout

The admin layout used to have overflow on sidebar and content elements, meaning that the actual body of the page wasn't scrollable. This was especially noticable on mobile browsers, as it made the "tab top of the window to scroll to top" function not work. This changes the layout. Now, the sidebar will not have a separate scrollbar either.

The identity proofs authorization page accidentally had the .admin class on the body, which made it unscrollable, so:

Fix #11838

@Gargron Gargron added the bug Something isn't working label Sep 19, 2019
Hide navigation behind hamburger icon on small screens in admin layout
@Gargron Gargron force-pushed the fix-admin-layout-scroll branch from 099d958 to 7b09e27 Compare September 19, 2019 18:47
@Gargron Gargron merged commit b9a8b38 into master Sep 20, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Hide navigation behind hamburger icon on small screens in admin layout
@Gargron Gargron deleted the fix-admin-layout-scroll branch December 30, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot scroll Keybase authorization page on mobile
2 participants